On Sat, 13 Feb 2010, Riccardo (Jack) Lucchetti wrote:
On Sat, 13 Feb 2010, Lars Pålsson-Syll wrote:
> Hi
> Thanks for the new NEGBIN command.
> I have tried it out using the PATENTS data in Verbeek (ch 7.3.2).
> However, using the Model menu it breaks down.
> Likewise if I try to use the NEGBIN1 alternative (--model1) in the console
> I get
> the message "The convergence criteria not met."
> A bug?
Two, actually. I haven't touched the first one (the GUI hook). The second
one, however, should be ok now in CVS. Please test!
The following patch ought to fix the GUI bug, but I'm not at all sure it's
the proper way to handle this, so it's _not_ in CVS. Allin, could you
please take a look when you have time?
Index: lib/src/gretl_model.c
===================================================================
RCS file: /cvsroot/gretl/gretl/lib/src/gretl_model.c,v
retrieving revision 1.310
diff -u -r1.310 gretl_model.c
--- lib/src/gretl_model.c 21 Nov 2009 17:34:43 -0000 1.310
+++ lib/src/gretl_model.c 14 Feb 2010 13:44:36 -0000
@@ -1510,7 +1510,7 @@
}
}
}
- } else if (pmod->ci == PANEL) {
+ } else if ((pmod->ci == PANEL) || (pmod->ci == NEGBIN)) {
nx = pmod->list[0] - 1;
list = gretl_list_new(nx);
if (list != NULL) {
Riccardo (Jack) Lucchetti
Dipartimento di Economia
Università Politecnica delle Marche
r.lucchetti(a)univpm.it
http://www.econ.univpm.it/lucchetti