Re: [Gretl-devel] Contribute to Gretl code (FIX for gnuplot 4.2).

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi all, First of all, my original message was not posted to the list yet. It is waiting for your approval because the size exceeds the default. Riccardo (Jack) Lucchetti wrote: | On Thu, 10 Apr 2008, Hélio Guilherme wrote: | |> -----BEGIN PGP SIGNED MESSAGE----- |> Hash: SHA1 |> |> Hi Allin, Jack and developers, |> |> I upgraded my gnuplot to it's latest version, 4.2, and then gretl's |> graphics got broken, like saving to a PNG. So here is a fix for it. |> |> New gnuplot 4.2 syntax made a change from "set term" to "set terminal". |> The fix modifies files in gui2 and also the configure script, to provide |> gnuplot version detection, and PNG support (it advises users to install |> PNG support in gnuplot). |> |> I decided to send the complete files and not patches because I am too |> lazy ;). |> |> Have fun, |> |> Hélio Guilherme |> | | It's great to receive patches. Thanks! | | However, I'm a bit surprised by your report. "set term" has always been | an abbreviation for "set terminal" in gnuplot. "set term" works just | fine on my version of gnuplot, which is 4.2. So, the only thing I can | think is that your local version of gnuplot does not accept for some | mysterious reasons the abbreviation "set term" instead of "set terminal" | (but then, gretl uses abbreviations of gnuplot commands a lot, like for | example "set outp" which, as far as I understand, works ok on your | system). What happens if you run gnuplot from a console and type in the | command "set term png" by hand? Surprisingly, it works all well. I do not remember if I did that test before. | If I were you, I'd consider sending a bug report to the gnuplot folks | reporting that "set term" doesn't work on your system (I may be missing | something, though). | | Anyway, I guess it's no harm to anyone to replace all occurrences of | "set term" to "set terminal" in the gretl source, which I'll try to do | later today. That must be done with care, because there are some commands that depend of the size of the command string, and are hard coded. There is at least one line that the original code is wrong in the size constant. | This should make you changes to the configure script unnecessary, except | for | | --- configure 2008-04-10 22:20:28.000000000 +0200 | +++ /home/jack/src/gretl/configure 2008-02-23 19:52:14.000000000 +0100 | @@ -25353,7 +25353,7 @@ | else | echo "*** Could not run LAPACK test program, checking why..." | CFLAGS="$LAPACK_CFLAGS $CFLAGS" | - LIBS="$LAPACK_LIBS $LIBS" | + LIBS="$LIBS $LAPACK_LIBS" | cat >conftest.$ac_ext <<_ACEOF | /* confdefs.h. */ | _ACEOF | | which look unrelated to gnuplot. Could you please explain what its | rationale is? That may be something from my past attempts to pass the LAPACK checking step. I only managed to pass, after changing the configure (and I did sent it to Allin some years ago :)). I did more changes in the script at the time, but that one was to have the blas library before the lapack. It solved my problem then (and I do not know if still exists). | In any case, please not that the configure script is automatically | generated. If you need to modify anything, you should edit configure.in | and run autoconf on it. Thanks (and to Allin too :) | Thanks again! | | | Riccardo (Jack) Lucchetti | Dipartimento di Economia | Università Politecnica delle Marche | | r.lucchetti(a)univpm.it | http://www.econ.univpm.it/lucchetti | | | ------------------------------------------------------------------------ | | _______________________________________________ | Gretl-devel mailing list | Gretl-devel(a)lists.wfu.edu | http://lists.wfu.edu/mailman/listinfo/gretl-devel