[Gretl-devel] Re: sscanf -> segfault
On Tue, 21 Sep 2021, Riccardo (Jack) Lucchetti wrote:
On Tue, 21 Sep 2021, Sven Schreiber wrote:
> Am 21.09.2021 um 14:51 schrieb Riccardo (Jack) Lucchetti:
>>
>> The "sscanf" command is deprecated, so this is probably not very
>> important, however: I just discovered a way to trigger a segfault.
>> Just open a console or gretlcli, type "sscanf" and hit Enter. Boom.
>>
>> Fortunately, the fix was easy and I just pushed it to git.
>>
> Thanks, Jack!
>
> Maybe it would be a good idea to trivially test all the commands that we
> have (or have had) by just typing them without any parameters, like you
> did with sscanf !?
Well, I'm not stopping you! ;)
Testing is always good, but I don't think this is something we need
get too excited about. The bug that Jack found was in an exceptional
case: a redirect from a defunct command to a function. For commands
that are in good standing we have guards in place against missing
arguments. OK, I can't guarantee that the guards are 100%
bullet-proof, but I'd say better than 99%.
Allin