[Gretl-devel] Re: basic questions/comments on X13
Am 23.11.2021 um 15:05 schrieb Allin Cottrell:
On Tue, 23 Nov 2021, Sven Schreiber wrote:
> Am 20.11.2021 um 23:34 schrieb Allin Cottrell:
>>>> It would be quite easy to add an optional bundle-of-options argument
>>>> to deseas(), to give as much control over the processing as is
>>>> offered by the GUI interface (perhaps more, if anyone's so
motivated).
> What would be great, is if all those options could be included as
> user-settable which then allow to replicate the presets in the following
> table:
>
https://jdemetradocumentation.github.io/JDemetra-documentation/pages/refe...
>
>
> I mean primarily RSA0...RSA5. If deseas() accepts an options bundle,
> putting together the bundles for those presets would be mostly trivial.
Thanks, that's very helpful. deseas() now accepts a bundle option (arg3)
and it shouldn't be too difficult to support the "packages" of options
defined by JDemetra. I'll offer some preliminary doc before long.
Hi, I've taken a look at current git master to see what's the status quo
there. AFAICS, the new bundle argument is being passed around internally
already, for example in seasonally_adjust_series() in lib/src/genfuncs.c
or in adjust_series() in plugin/tramo-x12a.c. However, nothing is done
with that bundle yet -- this is not a criticism but just to clarify
where we are, and so that we don't forget.
For example, if te choice between X13 and Tramo is given in the new
bundle (as opposed to the old string argument), the check in
seasonally_adjust_series needs to honor that. (lines 1337 and 1341, for
example) And the same for adjust_series (line 1997 in tramo-x12a.c).
Next, in the underlying adjust_series we have already the line (1999):
x13a_opts xopt = {3, 0, 0, 0, 0, 0, 0, 0, NADBL};
So it looks as if transferring any user options from the new options
bundle would be quite easy, the infrastructure is already there (for
x13). This in turn suggests that we need to specify the recognized or
admissible option names for the new bundle, right? Do you want me to
come up with suggestions?
thanks
sven