[Gretl-devel] Re: psdroot() error message
Am 23.02.2022 um 23:41 schrieb Allin Cottrell:
yOn Wed, 23 Feb 2022, Sven Schreiber wrote:
> Am 22.02.2022 um 15:38 schrieb Sven Schreiber:
>>> This is true but the error message is a very generic
"data error", see
>
> This is now in git such that for simple test cases I get "matrices not
> conformable for operation".
The reference to "matrices" (plural) in this case seems to me clearly
wrong. In git I've substituted E_INVARG, so the error message becomes
"Invalid argument". We could substitute a more specific message, such as
"psdroot: the argument must be square"
or perhaps a more generic version such as
"Expected a square matrix"
which could be attached to a new, reusable error code, E_NONSQUARE.
In each the cost would be a little more work for translators.
Thanks, IMHO the "invalid argument" together with the existing
documentation would be sufficient.
(BTW, a point of libgretl C coding style is that we never put white
space after an opening, or before a closing, parenthesis. Jack might
call that a "Taliban" requirement on my part, but it's an iron rule so
long as I'm above ground!)
You're talking about the round brackets, right? (Not visible in this
list message.) I have no problem with that rule.
But BTW, I saw that the whitespace in gretl_matrix.c was again (or
still) the emacs-style mix of spaces and tabs. It was my understanding
that we wanted to switch to spaces (blanks) only.
cheers
sven