[Gretl-devel] Re: ui-maker and no_const
On Sat, 27 Jul 2024, Sven Schreiber wrote:
Am 26.07.2024 um 19:30 schrieb Cottrell, Allin:
> On Fri, Jul 26, 2024 at 10:15 AM Sven Schreiber
> <sven.schreiber(a)fu-berlin.de> wrote:
>> - The package specifies "no-data-ok" and this also shows up in the
info.
>> However, when executing the package GUI, a warning dialog with "this
>> requires a dataset" appears.
> I think that's because your package depends on SVAR, which
requires
> time-series data.
Ah, good point. Although then the follow-up question why is it just
asking
for an unspecified dataset, and not for time series? Indeed I just tested
with the panel dataset abdata.gdt, and didn't get the error message, although
of course the underlying SVAR functions cannot do anything sensible with
panel data.
Hmm, sounds like that needs fixing.
>> - The GUI_SVAR_setID_uimaker function is declared as the
ui-maker, and
>> requests no_const both for the lists X and Y, as well as no_singleton for
>> Y. However, in the GUI I can execute the package under all those cases
>> that are supposed to be prevented.
>
> Your package doesn't seem to specify a menu attachment: that's
> required for the ui-maker to kick in.
Hm, I see. But what's required per the documentation strikes me as
reasonable, namely: "The ui-maker is called internally when the relevant
dialog box is to be shown" and "...the dialog box shown when the gui-main
function of a package is called". Why should the menu attachment be a
necessary ingredient there?
Fair question, I'll look into that.
Allin