[Gretl-devel] Re: off-by-one bug in $system.t1 (and .t2) after var
Am 20.11.2020 um 23:28 schrieb Allin Cottrell:
On Fri, 20 Nov 2020, Allin Cottrell wrote:
> IIRC the $system bundle for the "system" command came first and was
> added for VARs later. But anyway, in the "system" $system bundle the
> t1 and t2 values, which are always 0-based internally, are correctly
> mapped to 1-based user-space values but that's not happening for VARs.
> Should be easy enough to find the difference; I'll take a look.
The difference is between equation_system_bundlize() and
gretl_VAR_bundlize(): the former was converting to 1-based t1 and t2,
the latter not. The latter is now fixed in git.
OK great!
BTW I think some naming harmonization wouldn't hurt, either
gretl_system_bundlize (with gretl_) or VAR_bundlize (without gretl_). I
guess it could also just be system_bundlize.
Also for after release I would clean up the equation_system_estimate
function a little bit along the lines discussed.
thanks
sven