[Gretl-devel] Re: psdroot() error message
Am 13.02.2022 um 14:12 schrieb Sven Schreiber:
Hi, according to the doc for psdroot(): "If the input matrix is
not
square an error is flagged".
This is true but the error message is a very generic "data error", see
for example:
eval psdroot(ones(3,4))
Maybe a more informative message could be arranged?
It seems that the following snippet in lines 8416/8417 from
lib/src/gretl_matrix.c is responsible:
if (gretl_is_null_matrix(a) || a->rows != a->cols) {
return E_DATA;
Would it be OK to replace that with the following:
if (gretl_is_null_matrix(a)) {
return E_DATA;
} else if (a->rows != a->cols) {
return E_NONCONF;
}
thanks
sven