Hi, I think the string in the following line must still be marked for translation: gui/menustate.c: sprintf(tmp + 1, "Imported %s", basename); Do I understand correctly -to do it myself in the future- that it would have to be replaced with: N_("Imported %s") ?

Am 18.04.2020 um 15:16 schrieb Allin Cottrell: > On Sat, 18 Apr 2020, Sven Schreiber wrote: >> Do I understand correctly -to do it myself in the future- that it would >> have to be replaced with: >> N_("Imported %s") >> ? > > Almost. But the syntax N_(<string>) means "mark this string for > translation but don't actually translate it here". In this case you'd > want _("Imported %s") to get it translated in place. > > The N_() form is used in this kind of context: > > const char *s = N_("Something stringy"); /* mark it */ > ... > printf("%s\n", _(s)); /* actually translate it */ OK thanks. And is anything else needed so that translators get this change in their po files?

Am 19.04.2020 um 01:28 schrieb Allin Cottrell: > On Sat, 18 Apr 2020, Sven Schreiber wrote: > >> >> OK thanks. And is anything else needed so that translators get this >> change in their po files? > > cd <builddir>/po && make update-po > cd <source-dir> > git commit -a > git push > Hmm, OK thanks. But I'm confused about the <builddir>, that's not something that lives in git?

Am 19.04.2020 um 16:42 schrieb Allin Cottrell: > On Sun, 19 Apr 2020, Sven Schreiber wrote: >> Am 19.04.2020 um 01:28 schrieb Allin Cottrell: >>> On Sat, 18 Apr 2020, Sven Schreiber wrote: >>> >>>> OK thanks. And is anything else needed so that translators get this >>>> change in their po files? >>> >>> cd <builddir>/po && make update-po >>> cd <source-dir> >>> git commit -a >>> git push >>> >> Hmm, OK thanks. But I'm confused about the <builddir>, that's not >> something that lives in git? > > No, that's wherever you're running configure and make. > Right - so that means while translators work with the po files in git, and the underlying C source changes are also done in git, in between there's a necessary step that leaves the realm of the git tree?

Am 19.04.2020 um 17:57 schrieb Allin Cottrell: > On Sun, 19 Apr 2020, Sven Schreiber wrote: >> Am 19.04.2020 um 16:42 schrieb Allin Cottrell: >>> >>> No, that's wherever you're running configure and make. >>> >> Right - so that means while translators work with the po files in git, >> and the underlying C source changes are also done in git, in between >> there's a necessary step that leaves the realm of the git tree? > > If you're building outside of the source tree (which is generally > recommended), yes. The .po files are kind of a special case, generated > from the C sources (and so requiring a "make") but edited by the > translators thereafter. > So what's the preferred workflow for marking another string for translation? I'd say the first-step change in the C source would be enough, because eventually you (or somebody else) are going to run the po-update step when a bunch of new translation gaps have accumulated. No need to do it every time. Right?