11:35 a.m.
With current git, the command
<hansl>
string sep = "\"
</hansl>
works ok, but the conditional assignment statement
<hansl>
string sep = $windows ? "\" : "/"
</hansl>
gives an error, because the backslash is considered an escaping character.
This breaks the xy_color packages (and possibly some more).
More generally, the funny thing is that
<hansl>
string sep = 1 ? "/" : "\"
string sep = 0 ? "/" : "\"
</hansl>
both work ok, so I guess it has something to do with the parsing of the
command string.
I found out about this by chance, so I have no idea of how long this
(possible) bug has been there.
-------------------------------------------------------
Riccardo (Jack) Lucchetti
Dipartimento di Scienze Economiche e Sociali (DiSES)
Università Politecnica delle Marche
(formerly known as Università di Ancona)
r.lucchetti(a)univpm.it
http://www2.econ.univpm.it/servizi/hpp/lucchetti
-------------------------------------------------------
12:20 p.m.
Am 06.02.2020 um 12:35 schrieb Riccardo (Jack) Lucchetti:
works ok, but the conditional assignment statement
<hansl>
string sep = $windows ? "\" : "/"
</hansl>
gives an error, because the backslash is considered an escaping
character. This breaks the xy_color packages (and possibly some more).
The thread in December "problem with sprintf in ternary statement" looks
related. Allin fixed a bug there by removing a special-casing treatment
of \" , but this may be a side effect.
cheers
sven
5:49 p.m.
On Thu, 6 Feb 2020, Sven Schreiber wrote:
Am 06.02.2020 um 12:35 schrieb Riccardo (Jack) Lucchetti:
> works ok, but the conditional assignment statement
>
> <hansl>
> string sep = $windows ? "\" : "/"
> </hansl>
>
> gives an error, because the backslash is considered an escaping
> character. This breaks the xy_color packages (and possibly some more).
The thread in December "problem with sprintf in ternary statement" looks
related. Allin fixed a bug there by removing a special-casing treatment
of \" , but this may be a side effect.
Yes, it must be. I'll take another look at that.
Allin
7:19 p.m.
On Thu, 6 Feb 2020, Sven Schreiber wrote:
Am 06.02.2020 um 12:35 schrieb Riccardo (Jack) Lucchetti:
> works ok, but the conditional assignment statement
>
> <hansl>
> string sep = $windows ? "\" : "/"
> </hansl>
>
> gives an error, because the backslash is considered an escaping
> character. This breaks the xy_color packages (and possibly some more).
The thread in December "problem with sprintf in ternary statement" looks
related. Allin fixed a bug there by removing a special-casing treatment
of \" , but this may be a side effect.
OK, I've had a further go at fixing this in git. It seems there
_was_ a rationale for the old special-casing of backslash-quote in the
conditional assignment context, but it should be turned off whenever
the sub-context is sprintf().
Both of the following tests now work:
<hansl>
# Sven's case
string s = 1 ? sprintf("\"hey\"") : "other"
print s
# Jack's case
string sep = $windows ? "\" : "/"
print sep
</hansl>
Allin
8:08 p.m.
On Thu, 6 Feb 2020, Allin Cottrell wrote:
OK, I've had a further go at fixing this in git. It seems there
_was_ a rationale for the old special-casing of backslash-quote in the
conditional assignment context, but it should be turned off whenever
the sub-context is sprintf().
Both of the following tests now work:
<hansl>
# Sven's case
string s = 1 ? sprintf("\"hey\"") : "other"
print s
# Jack's case
string sep = $windows ? "\" : "/"
print sep
</hansl>
Confirmed working, and color_xy works ok too. Thanks, Allin!
-------------------------------------------------------
Riccardo (Jack) Lucchetti
Dipartimento di Scienze Economiche e Sociali (DiSES)
Università Politecnica delle Marche
(formerly known as Università di Ancona)
r.lucchetti(a)univpm.it
http://www2.econ.univpm.it/servizi/hpp/lucchetti
-------------------------------------------------------
9:54 a.m.
Am 06.02.2020 um 20:19 schrieb Allin Cottrell:
On Thu, 6 Feb 2020, Sven Schreiber wrote:
> Am 06.02.2020 um 12:35 schrieb Riccardo (Jack) Lucchetti:
>> <hansl>
>> string sep = $windows ? "\" : "/"
>> </hansl>
>>
>> gives an error, because the backslash is considered an escaping
>> character. This breaks the xy_color packages (and possibly some more).
>
> The thread in December "problem with sprintf in ternary statement" looks
> related. Allin fixed a bug there by removing a special-casing treatment
> of \" , but this may be a side effect.
OK, I've had a further go at fixing this in git. It seems there
_was_ a rationale for the old special-casing of backslash-quote in the
conditional assignment context, but it should be turned off whenever
the sub-context is sprintf().
Could you elaborate on this? In principle it seems that it only matters
whether we have a string literal or something inside sprintf. (Because
as per the doc the meaning of a backslash changes.)
I don't really understand why the ternary statement context is special
at all - OK I can understand it is more difficult to parse, but the same
complication would arise in some other syntactical constructs, no?
thanks
sven
7:54 p.m.
On Fri, 7 Feb 2020, Sven Schreiber wrote:
Am 06.02.2020 um 20:19 schrieb Allin Cottrell:
> On Thu, 6 Feb 2020, Sven Schreiber wrote:
>
> > Am 06.02.2020 um 12:35 schrieb Riccardo (Jack) Lucchetti:
> > > <hansl>
> > > string sep = $windows ? "\" : "/"
> > > </hansl>
> > >
> > > gives an error, because the backslash is considered an escaping
> > > character. This breaks the xy_color packages (and possibly some more).
> >
> > The thread in December "problem with sprintf in ternary statement"
looks
> > related. Allin fixed a bug there by removing a special-casing treatment
> > of \" , but this may be a side effect.
>
> OK, I've had a further go at fixing this in git. It seems there
> _was_ a rationale for the old special-casing of backslash-quote in the
> conditional assignment context, but it should be turned off whenever
> the sub-context is sprintf().
Could you elaborate on this? In principle it seems that it only matters
whether we have a string literal or something inside sprintf. (Because
as per the doc the meaning of a backslash changes.)
I don't really understand why the ternary statement context is special
at all - OK I can understand it is more difficult to parse, but the same
complication would arise in some other syntactical constructs, no?
The format string for sprintf() is very special and has its own
handler. In most uses a line of hansl that calls sprintf gets passed
on to the special handler straight away. When an sprintf call is
embedded in the conditional assignment context, however, we have to be
able to pick it out, extract it, and that's what can be tricky.
Allin
1780
days inactive
1781
days old
6 comments
3 participants
participants (3)
-
Allin Cottrell -
Riccardo (Jack) Lucchetti -
Sven Schreiber