11:54 a.m.
Two small questions on graphs (Not very important and not urgent at all):
Using gretl on Linux, if I draw a time series graph with two series, with the
default options, I can see on the screen the first series in red and the
second in blue, but if I click on the graph and select "save as EPS/color"
the second series is in a light green. I am trying to import some graphs to a
pdf presentation and the green color does not allow to apreciate well the
second series. Allin, could you change it to blue or do it respect the user
color selections? Thank you.
The second question is about the thickness of the graph lines. They appear
quite good at the screen but when I print a graph in a paper I think they are
too thin, and if I have to scale down the graph the lines are even thinner.
Could you look if there is a (non very problematic) way to improve this?
(I remember in R there is an option to scale up the thickness of the graphs
if you want to scale down the graph.)
--
Ignacio Diaz-Emparanza
DEPARTAMENTO DE ECONOMÍA APLICADA III (ECONOMETRÍA Y ESTADÍSTICA)
UPV/EHU
Avda. Lehendakari Aguirre, 83 | 48015 BILBAO
T.: +34 946013732 | F.: +34 946013754
www.et.bs.ehu.es
10:42 a.m.
Ignacio Diaz-Emparanza schrieb:
Two small questions on graphs (Not very important and not urgent at
all):
Using gretl on Linux, if I draw a time series graph with two series, with the
default options, I can see on the screen the first series in red and the
second in blue, but if I click on the graph and select "save as EPS/color"
the second series is in a light green. I am trying to import some graphs to a
pdf presentation and the green color does not allow to apreciate well the
second series. Allin, could you change it to blue or do it respect the user
color selections? Thank you.
I had the same problem not too long ago and IIRC also asked here. I
think it was gnuplot's postscript driver, and the solution was not
obvious (again, IIRC).
-sven
2:28 p.m.
On Sat, 29 Sep 2007, Sven Schreiber wrote:
Ignacio Diaz-Emparanza schrieb:
>
> Using gretl on Linux, if I draw a time series graph with two
> series, with the default options, I can see on the screen the
> first series in red and the second in blue, but if I click on
> the graph and select "save as EPS/color" the second series is
> in a light green. I am trying to import some graphs to a pdf
> presentation and the green color does not allow to apreciate
> well the second series. Allin, could you change it to blue or
> do it respect the user color selections? Thank you.
>
I had the same problem not too long ago and IIRC also asked
here. I think it was gnuplot's postscript driver, and the
solution was not obvious (again, IIRC).
I'm working on respecting the user color selections for EPS and
PDF output. I think I've got this now, but need to do a bit more
testing.
Allin.
3:58 p.m.
New subject: Small bug in seasonal dummies
I have a monthly dataset with the sample starting in 2003.10
If I execute the command
genr dummy
(or add/periodic dummies in the GUI) the generated variables does not contain
the "1" in the correct month. In concrete the variable "ddic" has the
"1" in
september.
--
Ignacio Diaz-Emparanza
DEPARTAMENTO DE ECONOMÍA APLICADA III (ECONOMETRÍA Y ESTADÍSTICA)
UPV/EHU
Avda. Lehendakari Aguirre, 83 | 48015 BILBAO
T.: +34 946013732 | F.: +34 946013754
www.et.bs.ehu.es
5:05 p.m.
New subject: Small bug in seasonal dummies
On Tue, 2 Oct 2007, Ignacio Diaz-Emparanza wrote:
I have a monthly dataset with the sample starting in 2003.10
If I execute the command
genr dummy
(or add/periodic dummies in the GUI) the generated variables does not contain
the "1" in the correct month. In concrete the variable "ddic" has the
"1" in
september.
Confirmed. The trouble is that the string "10" ends with the character
"0". If I'm not mistaken, the following patch should fix it. Basically, it
avoids conversion to strings. Allin, I ran just a limited series of tests,
so I'm not committing it myself. Could you take a look?
Index: lib/src/dataio.c
===================================================================
RCS file: /cvsroot/gretl/gretl/lib/src/dataio.c,v
retrieving revision 1.327
diff -u -w -u -r1.327 dataio.c
--- lib/src/dataio.c 27 Sep 2007 14:40:19 -0000 1.327
+++ lib/src/dataio.c 2 Oct 2007 17:02:30 -0000
@@ -912,27 +912,15 @@
ret = t % pdinfo->pd;
} else {
/* quarterly, monthly, hourly... */
- double x = date(t, pdinfo->pd, pdinfo->sd0);
- char *p, s[32];
- int i, n;
- sprintf(s, "%f", x);
- n = strlen(s);
- for (i=n-1; i>0; i--) {
- if (s[i] == '0') {
- s[i] = '\0';
- } else {
- break;
- }
- }
- p = strchr(s, '.');
- if (p == NULL) {
- p = strchr(s, ',');
- }
- if (p != NULL) {
- sscanf(p + 1, "%d", &ret);
- ret -= 1;
+ double ln10 = 2.30258509299404568401;
+ double x = date(t, pdinfo->pd, pdinfo->sd0);
+ x -= floor(x);
+ int i, scale = (int) (1 + log(pdinfo->pd)/ln10);
+ for(i=0; i<scale; i++) {
+ x *= 10;
}
+ ret = (int) x;
}
return ret;
Riccardo (Jack) Lucchetti
Dipartimento di Economia
Università Politecnica delle Marche
r.lucchetti(a)univpm.it
http://www.econ.univpm.it/lucchetti
5:10 p.m.
New subject: Small bug in seasonal dummies
On Tue, 2 Oct 2007, Riccardo (Jack) Lucchetti wrote:
Confirmed. The trouble is that the string "10" ends with
the character "0".
If I'm not mistaken, the following patch should fix it. Basically, it avoids
conversion to strings. Allin, I ran just a limited series of tests, so I'm
not committing it myself. Could you take a look?
Doh. I didn't know C had a "log10" builtin function. This one's better.
Index: lib/src/dataio.c
===================================================================
RCS file: /cvsroot/gretl/gretl/lib/src/dataio.c,v
retrieving revision 1.328
diff -u -w -u -r1.328 dataio.c
--- lib/src/dataio.c 2 Oct 2007 17:04:10 -0000 1.328
+++ lib/src/dataio.c 2 Oct 2007 17:09:04 -0000
@@ -912,19 +912,14 @@
ret = t % pdinfo->pd;
} else {
/* quarterly, monthly, hourly... */
- double x = date(t, pdinfo->pd, pdinfo->sd0);
- int d = ceil(log10(pdinfo->pd));
- char *p, s[32];
- sprintf(s, "%.*f", d, x);
- p = strchr(s, '.');
- if (p == NULL) {
- p = strchr(s, ',');
- }
- if (p != NULL) {
- sscanf(p + 1, "%d", &ret);
- ret -= 1;
+ double x = date(t, pdinfo->pd, pdinfo->sd0);
+ x -= floor(x);
+ int i, scale = (int) (1 + log10(pdinfo->pd));
+ for(i=0; i<scale; i++) {
+ x *= 10;
}
+ ret = (int) x;
}
return ret;
Riccardo (Jack) Lucchetti
Dipartimento di Economia
Università Politecnica delle Marche
r.lucchetti(a)univpm.it
http://www.econ.univpm.it/lucchetti
5:11 p.m.
New subject: Small bug in seasonal dummies
On Tue, 2 Oct 2007, Riccardo (Jack) Lucchetti wrote:
On Tue, 2 Oct 2007, Ignacio Diaz-Emparanza wrote:
> I have a monthly dataset with the sample starting in 2003.10
> If I execute the command
>
> genr dummy
>
> (or add/periodic dummies in the GUI) the generated variables does not
> contain
> the "1" in the correct month. In concrete the variable "ddic"
has the "1" in
> september.
Confirmed. The trouble is that the string "10" ends with the character
"0". If
I'm not mistaken, the following patch should fix it. Basically, it avoids
conversion to strings. Allin, I ran just a limited series of tests, so I'm not
committing it myself. Could you take a look? ...
Ah, we worked on this simultaneously. Do you think the fix I
committed is OK?
Allin.
5:19 p.m.
New subject: Small bug in seasonal dummies
On Tue, 2 Oct 2007, Allin Cottrell wrote:
On Tue, 2 Oct 2007, Riccardo (Jack) Lucchetti wrote:
> On Tue, 2 Oct 2007, Ignacio Diaz-Emparanza wrote:
>
>> I have a monthly dataset with the sample starting in 2003.10
>> If I execute the command
>>
>> genr dummy
>>
>> (or add/periodic dummies in the GUI) the generated variables does not
>> contain
>> the "1" in the correct month. In concrete the variable "ddic"
has the "1" in
>> september.
>
> Confirmed. The trouble is that the string "10" ends with the character
"0". If
> I'm not mistaken, the following patch should fix it. Basically, it avoids
> conversion to strings. Allin, I ran just a limited series of tests, so I'm not
> committing it myself. Could you take a look? ...
Ah, we worked on this simultaneously. Do you think the fix I
committed is OK?
It seems to me it is. However, I'd rather avoid strings. Would this one
(which grabs a couple of things from yours) be ok to you?
Index: lib/src/dataio.c
===================================================================
RCS file: /cvsroot/gretl/gretl/lib/src/dataio.c,v
retrieving revision 1.328
diff -u -w -u -r1.328 dataio.c
--- lib/src/dataio.c 2 Oct 2007 17:04:10 -0000 1.328
+++ lib/src/dataio.c 2 Oct 2007 17:16:22 -0000
@@ -912,19 +912,14 @@
ret = t % pdinfo->pd;
} else {
/* quarterly, monthly, hourly... */
- double x = date(t, pdinfo->pd, pdinfo->sd0);
- int d = ceil(log10(pdinfo->pd));
- char *p, s[32];
- sprintf(s, "%.*f", d, x);
- p = strchr(s, '.');
- if (p == NULL) {
- p = strchr(s, ',');
- }
- if (p != NULL) {
- sscanf(p + 1, "%d", &ret);
- ret -= 1;
+ double x = date(t, pdinfo->pd, pdinfo->sd0);
+ x -= floor(x);
+ int i, d = ceil(log10(pdinfo->pd));
+ for(i=0; i<d; i++) {
+ x *= 10;
}
+ ret = (int) x;
}
return ret;
Riccardo (Jack) Lucchetti
Dipartimento di Economia
Università Politecnica delle Marche
r.lucchetti(a)univpm.it
http://www.econ.univpm.it/lucchetti
5:37 p.m.
New subject: Small bug in seasonal dummies
On Tue, 2 Oct 2007, Riccardo (Jack) Lucchetti wrote:
} else {
/* quarterly, monthly, hourly... */
- double x = date(t, pdinfo->pd, pdinfo->sd0);
- int d = ceil(log10(pdinfo->pd));
- char *p, s[32];
- sprintf(s, "%.*f", d, x);
- p = strchr(s, '.');
- if (p == NULL) {
- p = strchr(s, ',');
- }
- if (p != NULL) {
- sscanf(p + 1, "%d", &ret);
- ret -= 1;
+ double x = date(t, pdinfo->pd, pdinfo->sd0);
+ x -= floor(x);
+ int i, d = ceil(log10(pdinfo->pd));
+ for(i=0; i<d; i++) {
+ x *= 10;
}
+ ret = (int) x;
I agree it would be more elegant to avoid strings, but I'm afraid
this works right only because (double) 10 = 9.9999999999909051.
We return a zero-based index (9 in this case). What one would
like to do is
ret = (int) x - 1;
for exact x. But it's going to screw up if x is not exact.
Allin.
5:09 p.m.
New subject: Small bug in seasonal dummies
On Tue, 2 Oct 2007, Ignacio Diaz-Emparanza wrote:
I have a monthly dataset with the sample starting in 2003.10
If I execute the command
genr dummy
(or add/periodic dummies in the GUI) the generated variables
does not contain the "1" in the correct month.
Well spotted. This is now fixed in CVS and Windows snapshot.
Allin.
6290
days inactive
6294
days old
9 comments
4 participants
participants (4)
-
Allin Cottrell -
Ignacio Diaz-Emparanza -
Riccardo (Jack) Lucchetti -
Sven Schreiber